Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Abort rollout removes all canary pods for setCanaryScale. Fixes #1337 #1352

Merged
merged 1 commit into from
Jul 26, 2021
Merged

fix: Abort rollout removes all canary pods for setCanaryScale. Fixes #1337 #1352

merged 1 commit into from
Jul 26, 2021

Conversation

csamant-salesforce
Copy link
Contributor

@csamant-salesforce csamant-salesforce commented Jul 15, 2021 •
edited
Loading

Signed-off-by: Chinmoy Samant [email protected]

fixes #1337

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@csamant-salesforce csamant-salesforce force-pushed the 1337-fix-abort-rollout-setcanaryscale branch from 5c3fe21 to 1548668 Compare July 15, 2021 22:06
@sonarcloud
Copy link

sonarcloud bot commented Jul 15, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@huikang
Copy link
Member

huikang commented Jul 20, 2021

LGTM

@huikang
Copy link
Member

huikang commented Jul 20, 2021

Need maintainer to approve running the ci, @jessesuen . Thanks.

@csamant-salesforce
Copy link
Contributor Author

@jessesuen Would appreciate your feedback/approval to move forward with the CI build. Thanks!

@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #1352 (1548668) into master (4a7978f) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1352      +/-   ##
==========================================
- Coverage   81.27%   81.26%   -0.01%     
==========================================
  Files         107      108       +1     
  Lines        9824    10033     +209     
==========================================
+ Hits         7984     8153     +169     
- Misses       1297     1319      +22     
- Partials      543      561      +18
Impacted Files Coverage Δ
utils/replicaset/canary.go 81.65% <0.00%> (-0.76%) ⬇️
experiments/experiment.go 89.18% <0.00%> (-2.48%) ⬇️
utils/replicaset/replicaset.go 89.47% <0.00%> (-0.24%) ⬇️
rollout/bluegreen.go 70.91% <0.00%> (ø)
experiments/service.go 69.84% <0.00%> (ø)
rollout/sync.go 76.47% <0.00%> (+0.04%) ⬆️
experiments/controller.go 69.13% <0.00%> (+0.10%) ⬆️
rollout/canary.go 78.46% <0.00%> (+0.73%) ⬆️
utils/defaults/defaults.go 88.70% <0.00%> (+2.99%) ⬆️
experiments/replicaset.go 85.89% <0.00%> (+3.22%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a7978f...1548668. Read the comment docs.

@jessesuen jessesuen merged commit 6fb2bcc into argoproj:master Jul 26, 2021
jessesuen pushed a commit to jessesuen/argo-rollouts that referenced this pull request Jul 26, 2021
@csamant-salesforce @jessesuen
fix: Abort rollout doesn't remove all canary pods for setCanaryScale (a…
8b53b2c 
…rgoproj#1352)

Signed-off-by: Chinmoy Samant <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessesuen jessesuen jessesuen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Abort rollout does not remove all canary pods for setCanaryScale
3 participants
@csamant-salesforce @huikang @jessesuen